ref(aws-serverless): Vendor aws-sdk instrumentation#20988
Merged
Conversation
Closes #20514 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Previously a transitive dependency of @opentelemetry/instrumentation-aws-sdk, now needed directly by the vendored code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
|
@nicohrubec does this close #19237 ? |
Member
Author
|
@aldenquimby it does not |
JPeer264
approved these changes
May 20, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
LGTM. Those are quite some new files :D
| packageSpecificConfig: { | ||
| // Used for our custom eventContextExtractor | ||
| external: ['@opentelemetry/api'], | ||
| output: { |
Member
There was a problem hiding this comment.
m: Checking-in was this done on purpose?
Member
Author
There was a problem hiding this comment.
it was, build failed without this because the paths changed
| * | ||
| * NOTICE from the Sentry authors: | ||
| * - Vendored from: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/15ef7506553f631ea4181391e0c5725a56f0d082/packages/instrumentation-aws-sdk | ||
| * - Upstream version: @opentelemetry/instrumentation-aws-sdk@0.73.0 |
Member
There was a problem hiding this comment.
m: I just cross-checked the vendored version is different than the vendored one, so we theoretically just also upgraded this instrumentation. Is this wanted? (as it is part as ref in the commit)
Member
Author
There was a problem hiding this comment.
as discussed for these cases it should be fine. I am checking the changelog for each and use the latest if there are no notable changes
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5a671b6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors
@opentelemetry/instrumentation-aws-sdkinto the SDK with no logic changes.TokenUsageandConverseStreamOutputtypes from@aws-sdk/client-bedrock-runtimeare inlined as simplified interfaces to avoid requiring the package as a dependency.Closes #20942